[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/13] QemuOpts: Convert qemu_opt_set_number() t
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 02/13] QemuOpts: Convert qemu_opt_set_number() to Error, fix its use |
Date: |
Mon, 16 Feb 2015 13:26:38 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/16/2015 07:44 AM, Markus Armbruster wrote:
> Return the Error object instead of reporting it with
> qerror_report_err().
>
> Change callers that assume the function can't fail to pass
> &error_abort, so that should the assumption ever break, it'll break
> noisily.
>
> Turns out all callers outside its unit test assume that. We could
> drop the Error ** argument, but that would make the interface less
> regular, so don't.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> block.c | 6 +++---
> block/nbd.c | 3 ++-
> block/qcow2.c | 2 +-
> block/vvfat.c | 3 ++-
> include/qemu/option.h | 3 ++-
> qemu-img.c | 3 ++-
> tests/test-qemu-opts.c | 16 ++++++++--------
> util/qemu-option.c | 9 ++++-----
> vl.c | 2 +-
> 9 files changed, 25 insertions(+), 22 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 13/13] qtest: Use qemu_opt_set() instead of qemu_opts_parse(), (continued)
- [Qemu-devel] [PATCH 13/13] qtest: Use qemu_opt_set() instead of qemu_opts_parse(), Markus Armbruster, 2015/02/16
- [Qemu-devel] [PATCH 09/13] qemu-img: Suppress unhelpful extra errors in convert, amend, Markus Armbruster, 2015/02/16
- [Qemu-devel] [PATCH 01/13] QemuOpts: Convert qemu_opt_set_bool() to Error, fix its use, Markus Armbruster, 2015/02/16
- [Qemu-devel] [PATCH 11/13] qemu-sockets: Simplify setting numeric and boolean options, Markus Armbruster, 2015/02/16
- [Qemu-devel] [PATCH 02/13] QemuOpts: Convert qemu_opt_set_number() to Error, fix its use, Markus Armbruster, 2015/02/16
- Re: [Qemu-devel] [PATCH 02/13] QemuOpts: Convert qemu_opt_set_number() to Error, fix its use,
Eric Blake <=
- [Qemu-devel] [PATCH 08/13] QemuOpts: Propagate errors through opts_parse(), Markus Armbruster, 2015/02/16
- [Qemu-devel] [PATCH 12/13] pc: Use qemu_opt_set() instead of qemu_opts_parse(), Markus Armbruster, 2015/02/16
- [Qemu-devel] [PATCH 05/13] block: Suppress unhelpful extra errors in bdrv_img_create(), Markus Armbruster, 2015/02/16
- [Qemu-devel] [PATCH 07/13] QemuOpts: Propagate errors through opts_do_parse(), Markus Armbruster, 2015/02/16
- [Qemu-devel] [PATCH 06/13] QemuOpts: Drop qemu_opt_set(), rename qemu_opt_set_err(), fix use, Markus Armbruster, 2015/02/16