[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 12/12] target-arm: A64: Avoid signed shifts in disas_
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PULL 12/12] target-arm: A64: Avoid signed shifts in disas_ldst_pair() |
Date: |
Fri, 13 Feb 2015 05:54:45 +0000 |
Avoid shifting potentially negative signed offset values in
disas_ldst_pair() by keeping the offset in a uint64_t rather
than an int64_t.
Signed-off-by: Peter Maydell <address@hidden>
Message-id: address@hidden
---
target-arm/translate-a64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
index 68c5b23..9f54501 100644
--- a/target-arm/translate-a64.c
+++ b/target-arm/translate-a64.c
@@ -1917,7 +1917,7 @@ static void disas_ldst_pair(DisasContext *s, uint32_t
insn)
int rt = extract32(insn, 0, 5);
int rn = extract32(insn, 5, 5);
int rt2 = extract32(insn, 10, 5);
- int64_t offset = sextract32(insn, 15, 7);
+ uint64_t offset = sextract64(insn, 15, 7);
int index = extract32(insn, 23, 2);
bool is_vector = extract32(insn, 26, 1);
bool is_load = extract32(insn, 22, 1);
--
1.9.1
- [Qemu-devel] [PULL 00/12] target-arm queue, Peter Maydell, 2015/02/13
- [Qemu-devel] [PULL 09/12] target-arm: A64: Fix shifts into sign bit, Peter Maydell, 2015/02/13
- [Qemu-devel] [PULL 11/12] target-arm: A64: Avoid left shifting negative integers in disas_pc_rel_addr, Peter Maydell, 2015/02/13
- [Qemu-devel] [PULL 10/12] target-arm: A64: Fix handling of rotate in logic_imm_decode_wmask, Peter Maydell, 2015/02/13
- [Qemu-devel] [PULL 08/12] target-arm: Add AArch32 guest support to KVM64, Peter Maydell, 2015/02/13
- [Qemu-devel] [PULL 05/12] target-arm: Add CPU property to disable AArch64, Peter Maydell, 2015/02/13
- [Qemu-devel] [PULL 04/12] pci: Move PCI VGA to pci.mak, Peter Maydell, 2015/02/13
- [Qemu-devel] [PULL 01/12] pci: Allocate PCIe host bridge PCI ID, Peter Maydell, 2015/02/13
- [Qemu-devel] [PULL 03/12] arm: Add PCIe host bridge in virt machine, Peter Maydell, 2015/02/13
- [Qemu-devel] [PULL 02/12] pci: Add generic PCIe host bridge, Peter Maydell, 2015/02/13
- [Qemu-devel] [PULL 12/12] target-arm: A64: Avoid signed shifts in disas_ldst_pair(),
Peter Maydell <=
- [Qemu-devel] [PULL 06/12] target-arm: Add feature parsing to virt, Peter Maydell, 2015/02/13
- [Qemu-devel] [PULL 07/12] target-arm: Add 32/64-bit register sync, Peter Maydell, 2015/02/13
- Re: [Qemu-devel] [PULL 00/12] target-arm queue, Peter Maydell, 2015/02/13
- Re: [Qemu-devel] [PULL 00/12] target-arm queue, Peter Maydell, 2015/02/13