[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 07/10] tpm: Avoid qerror_report_err() outside QMP
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v2 07/10] tpm: Avoid qerror_report_err() outside QMP command handlers |
Date: |
Thu, 12 Feb 2015 14:33:57 +0100 |
qerror_report_err() is a transitional interface to help with
converting existing monitor commands to QMP. It should not be used
elsewhere. Replace by error_report_err() in initial startup helper
configure_tpm().
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
tpm.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tpm.c b/tpm.c
index c371023..4ffd9b9 100644
--- a/tpm.c
+++ b/tpm.c
@@ -162,8 +162,7 @@ static int configure_tpm(QemuOpts *opts)
/* validate backend specific opts */
qemu_opts_validate(opts, be->opts, &local_err);
if (local_err) {
- qerror_report_err(local_err);
- error_free(local_err);
+ error_report_err(local_err);
return 1;
}
@@ -174,8 +173,7 @@ static int configure_tpm(QemuOpts *opts)
tpm_backend_open(drv, &local_err);
if (local_err) {
- qerror_report_err(local_err);
- error_free(local_err);
+ error_report_err(local_err);
return 1;
}
--
1.9.3
- [Qemu-devel] [PATCH v2 00/10] Clean up around error_get_pretty(), qerror_report_err(), Markus Armbruster, 2015/02/12
- [Qemu-devel] [PATCH v2 01/10] error: New convenience function error_report_err(), Markus Armbruster, 2015/02/12
- [Qemu-devel] [PATCH v2 08/10] vl: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/12
- [Qemu-devel] [PATCH v2 07/10] tpm: Avoid qerror_report_err() outside QMP command handlers,
Markus Armbruster <=
- [Qemu-devel] [PATCH v2 04/10] monitor: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/12
- [Qemu-devel] [PATCH v2 03/10] monitor: Clean up around monitor_handle_fd_param(), Markus Armbruster, 2015/02/12
- [Qemu-devel] [PATCH v2 02/10] error: Use error_report_err() where appropriate, Markus Armbruster, 2015/02/12
- [Qemu-devel] [PATCH v2 10/10] qemu-char: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/12
- [Qemu-devel] [PATCH v2 06/10] numa: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/12
- [Qemu-devel] [PATCH v2 05/10] net: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/12
- [Qemu-devel] [PATCH v2 09/10] qemu-img: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/12