[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/8] leon3: Replace unchecked qdev_init() by qde
|
From: |
Fabien Chouteau |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/8] leon3: Replace unchecked qdev_init() by qdev_init_nofail() |
|
Date: |
Thu, 12 Feb 2015 10:30:31 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/04/2015 06:33 PM, Markus Armbruster wrote:
> grlib_irqmp_create(), grlib_gptimer_create() and
> grlib_apbuart_create() are helpers to create and realize GRLIB
> devices. Their only caller leon3_generic_hw_init() doesn't check for
> failure. Only the first can actually fail, and only when the caller
> fails to set up a pointer property, which is a programming error.
>
> Replace qdev_init() by qdev_init_nofail().
>
> Cc: Fabien Chouteau <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Fabien Chouteau <address@hidden>
Thanks Markus,
- [Qemu-devel] [PATCH 0/8] Cleanups around unchecked qdev_init(), Markus Armbruster, 2015/02/04
- [Qemu-devel] [PATCH 1/8] qdev: Improve qdev_init_nofail()'s error reporting, Markus Armbruster, 2015/02/04
- [Qemu-devel] [PATCH 2/8] ide/isa: Replace unchecked qdev_init() by qdev_init_nofail(), Markus Armbruster, 2015/02/04
- [Qemu-devel] [PATCH 3/8] leon3: Replace unchecked qdev_init() by qdev_init_nofail(), Markus Armbruster, 2015/02/04
- Re: [Qemu-devel] [PATCH 3/8] leon3: Replace unchecked qdev_init() by qdev_init_nofail(),
Fabien Chouteau <=
- [Qemu-devel] [PATCH 4/8] etsec: Replace qdev_init() by qdev_init_nofail(), Markus Armbruster, 2015/02/04
- [Qemu-devel] [PATCH 6/8] serial: serial_hds_isa_init() shouldn't fail, Markus Armbruster, 2015/02/04
- [Qemu-devel] [PATCH 8/8] parallel: parallel_hds_isa_init() shouldn't fail, Markus Armbruster, 2015/02/04
- [Qemu-devel] [PATCH 7/8] parallel: Factor out common parallel_hds_isa_init(), Markus Armbruster, 2015/02/04
- [Qemu-devel] [PATCH 5/8] serial: Factor out common serial_hds_isa_init(), Markus Armbruster, 2015/02/04