[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/4] bootdevcie: change the boot order valida
From: |
Gonglei |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/4] bootdevcie: change the boot order validation logic |
Date: |
Thu, 12 Feb 2015 15:53:38 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 2015/2/7 15:20, Gonglei (Arei) wrote:
> From: Gonglei <address@hidden>
>
> The reset logic can be done by both machine reset and
> boot handler. So we shouldn't return error when the boot
> handler callback don't be set in patch 1.
>
> Patch 2 check boot order argument validation
> before vm running.
>
> Patch 3 passing &error_abort instead of NULL.
> Patch 4 update boot order in MachineState in qemu_boot_set
> in order to support changing boot order on other machine type,
> such as sPAPR.
>
> v3 -> v2:
> - rework patch 2 using clearer variable name and coding order. (Maruks)
> - add patch 4 in this patch series because of relevance.
>
> v2 -> v1:
> - add patch 2 suggested by Markus.
> - rework patch 3. (Maruks)
> - add R-by in patch 1.
>
> Dinar Valeev (1):
> bootdevice: update boot_order in MachineState
>
> Gonglei (3):
> bootdevice: remove the check about boot_set_handler
> bootdevice: check boot order argument validation before vm running
> bootdevice: add check in restore_boot_order()
>
> bootdevice.c | 16 ++++++++--------
> vl.c | 23 +++++++++++++++--------
> 2 files changed, 23 insertions(+), 16 deletions(-)
>
Any ideas, Markus? Thanks.
With the Chinese new year during near, a seven day holiday has already
on the way. So I plan to send a pull request on this Sunday. :)
Regards,
-Gonglei
- [Qemu-devel] [PATCH v3 3/4] bootdevice: add check in restore_boot_order(), (continued)