Re: [Qemu-devel] [PATCH v3] Fixes several full screen issues on Mac OS X

[Programmingkid]

On Feb 11, 2015, at 10:06 PM, Peter Maydell wrote:

> On 21 January 2015 at 19:25, Programmingkid <address@hidden> wrote:
>> This patch makes several changes:
>> - Minimizes distorted full screen display by respecting aspect
>> ratios.
>> - Makes full screen mode available on Mac OS 10.7 and higher.
>> - Allows user to decide if video should be stretched to fill the
>> screen, using a menu item called "Zoom To Fit".
>> - Hides the normalWindow so it won't show up in full screen mode.
>> - Allows user to exit full screen mode.
>> 
>> Signed-off-by: John Arbuckle <address@hidden>
>> 
>> ---
>> Changes in version 2:
>> - Completely rewritten.
>> - Eliminated depreciated API's.
>> - Does not change host monitor resolution.
>> 
>> Change in version 3:
>> - Fixed full screen window not receiving mouse moved events.
> 
> Thanks; this patch seems to make fullscreen work pretty well
> for me. Some oddities I noticed:
> 
> (1) This doesn't enable the green "fullscreen" button in
> OSX 10.9.5, so you have to fullscreen via the menu. That
> seems a shame, but if it's too hard to implement I can
> live without it.

I don't use Mac OS 10.9, so I don't know how to implement it 
right now. But it could be implemented in its own patch later. 

> 
> (2) Maybe zoom-to-fit should be the default? I think that's
> how we handle fullscreen on other UIs, and it seems like the
> most intuitive thing for it to do.

Zoom To Fit makes the screen look weird and text unreadable. 
I would prefer to have the full screen look good in full screen.

> 
> (3) If you are fullscreened then the only way to get out of it
> seems to be to first hit ctrl+alt to get out of the mouse
> grab, and then command-F to un-fullscreen. This isn't very
> obvious, but I can't think of a better thing right now so
> I guess it's OK.

That is the way to do it. If we designate one of the keys on the 
keyboard as the "Get out of full screen" button, we would not 
be able to use it in the guest. 

> 
> Otherwise the patch itself looks good.

Thank you.

> 
> A non-fullscreen related bug I noticed:
> 
> (4) if you have the mouse grabbed and use ctrl-up to enter Expose
> (or whatever Apple call that "show all the virtual desktops"
> mode) we don't un-grab the mouse. We should either release the
> grab or not let OSX steal ctrl-up when grabbed. This isn't
> a fullscreen related thing, though, so nothing to do with this
> patch; I just happened to spot it while testing this.

I haven't used control-up to use expose. It was always one of the function
keys for me.