[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_repor
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err() |
|
Date: |
Wed, 11 Feb 2015 11:17:40 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 10/02/2015 23:04, Eduardo Habkost wrote:
> $ spatch --sp-file /tmp/error_report.spatch $(git grep -l error_report) >
> /tmp/error_report.patch
Does it work without specifying any include path?
I tried this a while ago:
@@
identifier s, fld;
@@
struct s {
...
- QEMUTimer *fld;
+ QEMUTimer fld;
...
}
@@
expression E;
identifier fld;
@@
- E->fld = timer_new_ms(
+ timer_init_ms(&E->fld,
...
);
(The patch is incomplete, but shows the problem). "spatch --sp-file
timer.cocci hw/arm/pxa2xx.c" misses the first replacement for struct
PXA2xxRTCState, but "spatch --sp-file timer.cocci hmp.c" does it right
in struct MigrationStatus.
Paolo
- [Qemu-devel] [PATCH 0/9] Clean up around error_get_pretty(), qerror_report_err(), Markus Armbruster, 2015/02/10
- [Qemu-devel] [PATCH 3/9] monitor: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/10
- [Qemu-devel] [PATCH 6/9] tpm: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/10
- [Qemu-devel] [PATCH 2/9] monitor: Clean up around monitor_handle_fd_param(), Markus Armbruster, 2015/02/10
- [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err(), Markus Armbruster, 2015/02/10
- Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err(), Markus Armbruster, 2015/02/11
- Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err(), Eric Blake, 2015/02/10
[Qemu-devel] [PATCH 7/9] vl: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/10
[Qemu-devel] [PATCH 5/9] numa: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/10
[Qemu-devel] [PATCH 9/9] qemu-char: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/10
[Qemu-devel] [PATCH 8/9] qemu-img: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/10
[Qemu-devel] [PATCH 4/9] net: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/10