[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 10/12] qcow2/overlaps: Protect inactive L1 tables
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v3 10/12] qcow2/overlaps: Protect inactive L1 tables |
Date: |
Mon, 9 Feb 2015 14:25:48 -0500 |
Keep track of the inactive L1 tables in the metadata list to protect
them against accidental modifications.
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
block/qcow2-snapshot.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c
index c32d889..b3122d8 100644
--- a/block/qcow2-snapshot.c
+++ b/block/qcow2-snapshot.c
@@ -121,6 +121,21 @@ int qcow2_read_snapshots(BlockDriverState *bs)
ret = -EFBIG;
goto fail;
}
+
+ if (!(s->overlap_check & QCOW2_OL_INACTIVE_L1)) {
+ continue;
+ }
+
+ if (sn->l1_size > INT_MAX / sizeof(uint64_t)) {
+ /* Do not fail opening the image because a snapshot is broken which
+ * might not be used anyway */
+ continue;
+ }
+
+ qcow2_metadata_list_enter(bs, sn->l1_table_offset,
+ size_to_clusters(s, sn->l1_size *
+ sizeof(uint64_t)),
+ QCOW2_OL_INACTIVE_L1);
}
assert(offset - s->snapshots_offset <= INT_MAX);
@@ -416,6 +431,11 @@ int qcow2_snapshot_create(BlockDriverState *bs,
QEMUSnapshotInfo *sn_info)
g_free(l1_table);
l1_table = NULL;
+ qcow2_metadata_list_enter(bs, sn->l1_table_offset,
+ size_to_clusters(s, sn->l1_size *
+ sizeof(uint64_t)),
+ QCOW2_OL_INACTIVE_L1);
+
/*
* Increase the refcounts of all clusters and make sure everything is
* stable on disk before updating the snapshot table to contain a pointer
@@ -636,6 +656,11 @@ int qcow2_snapshot_delete(BlockDriverState *bs,
g_free(sn.id_str);
g_free(sn.name);
+ qcow2_metadata_list_remove(bs, sn.l1_table_offset,
+ size_to_clusters(s, sn.l1_size *
+ sizeof(uint64_t)),
+ QCOW2_OL_INACTIVE_L1);
+
/*
* Now decrease the refcounts of clusters referenced by the snapshot and
* free the L1 table.
--
2.1.0
- [Qemu-devel] [PATCH v3 01/12] qcow2: Add new overlap check functions, (continued)
- [Qemu-devel] [PATCH v3 01/12] qcow2: Add new overlap check functions, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v3 03/12] qcow2: Create metadata list, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v3 08/12] qcow2/overlaps: Protect active L2 tables, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v3 04/12] qcow2/overlaps: Protect image header, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v3 12/12] qcow2: Use new metadata overlap check function, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v3 09/12] qcow2/overlaps: Protect snapshot table, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v3 10/12] qcow2/overlaps: Protect inactive L1 tables,
Max Reitz <=
- [Qemu-devel] [PATCH v3 11/12] qcow2/overlaps: Protect inactive L2 tables, Max Reitz, 2015/02/09
- Re: [Qemu-devel] [PATCH v3 00/12] qcow2: Add new overlap check functions, Eric Blake, 2015/02/10
- Re: [Qemu-devel] [PATCH v3 00/12] qcow2: Add new overlap check functions, Max Reitz, 2015/02/27