[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 05/16] blockdev: Use blk_new_open() in blockd
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 05/16] blockdev: Use blk_new_open() in blockdev_init() |
Date: |
Thu, 05 Feb 2015 13:23:10 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/05/2015 11:58 AM, Max Reitz wrote:
> Due to different error propagation, this breaks tests 051 and 087; fix
> their output.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> blockdev.c | 92
> +++++++++++++++++++++-------------------------
> tests/qemu-iotests/051.out | 62 +++++++++++++++----------------
> tests/qemu-iotests/087.out | 8 ++--
> 3 files changed, 77 insertions(+), 85 deletions(-)
>
>
> Testing: -drive file=TEST_DIR/t.qcow2,driver=qcow2,format=qcow2
> -QEMU_PROG: -drive file=TEST_DIR/t.qcow2,driver=qcow2,format=qcow2: could not
> open disk image TEST_DIR/t.qcow2: Driver specified twice
> +QEMU_PROG: -drive file=TEST_DIR/t.qcow2,driver=qcow2,format=qcow2: Cannot
> specify both 'driver' and 'format'
This one is a nice improvement; I'm glad we added the test in 4/16.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v4 00/16] block: Remove "growable", add blk_new_open(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 04/16] iotests: Add test for driver=qcow2, format=qcow2, Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 01/16] block: Lift some BDS functions to the BlockBackend, Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 05/16] blockdev: Use blk_new_open() in blockdev_init(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 03/16] block: Add Error parameter to bdrv_find_protocol(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 07/16] qemu-img: Use blk_new_open() in img_open(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 06/16] block/xen: Use blk_new_open() in blk_connect(), Max Reitz, 2015/02/05