[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/19] qtest/ahci: rename 'Command' to 'Comma
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 03/19] qtest/ahci: rename 'Command' to 'CommandHeader' |
Date: |
Thu, 5 Feb 2015 13:06:55 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Feb 03, 2015 at 04:46:23PM -0500, John Snow wrote:
> The structure name is a bit of a misnomer; the structure currently named
> command is actually the commandheader. A future patch in this series
> will add an actual "Command" structure, so we'll rename it now before the
> rest of the functions in this series try to use it.
>
> In addition, rename the "b1" and "b2" fields
> to be a unified uint16_t named "flags."
>
> Signed-off-by: John Snow <address@hidden>
> ---
> tests/ahci-test.c | 8 ++++----
> tests/libqos/ahci.h | 7 +++----
> 2 files changed, 7 insertions(+), 8 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
pgpNoXTvd4yPr.pgp
Description: PGP signature
- [Qemu-devel] [PATCH v2 00/19] qtest/ahci: add dma test, John Snow, 2015/02/03
- [Qemu-devel] [PATCH v2 05/19] libqos/ahci: Add ahci_port_check_error helper, John Snow, 2015/02/03
- [Qemu-devel] [PATCH v2 04/19] libqos/ahci: Add command header helpers, John Snow, 2015/02/03
- [Qemu-devel] [PATCH v2 11/19] libqos/ahci: Add ide cmd properties, John Snow, 2015/02/03
- [Qemu-devel] [PATCH v2 07/19] libqos/ahci: Add port_check_nonbusy helper, John Snow, 2015/02/03