|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 0/8] machine: query machine properties rather than qemu opts |
Date: | Wed, 04 Feb 2015 17:00:48 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 04/02/2015 16:43, Marcel Apfelbaum wrote: > Commit e79d5a6 ("machine: remove qemu_machine_opts global list") removed > option > descriptions from the -machine QemuOptsList to avoid repeating MachineState's > QOM properties. > > This results in a Qemu crash if a non string option is queried using qemu > opts. > Fix this by querying machine properties through designated wrappers. Wrappers vs. direct access to fields is just a matter of taste, so Reviewed-by: Paolo Bonzini <address@hidden>
[Prev in Thread] | Current Thread | [Next in Thread] |