[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 11/26] qcow2: More helpers for refcount modif
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v5 11/26] qcow2: More helpers for refcount modification |
Date: |
Wed, 4 Feb 2015 14:53:45 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 15.12.2014 um 13:50 hat Max Reitz geschrieben:
> Add helper functions for getting and setting refcounts in a refcount
> array for any possible refcount order, and choose the correct one during
> refcount initialization.
>
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
Hm... Wouldn't it be better to have a single generic implementation that
is based on uint64_t* and calculates the right shifts and bitmasks on
the fly?
Kevin
- Re: [Qemu-devel] [PATCH v5 11/26] qcow2: More helpers for refcount modification,
Kevin Wolf <=