[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/2] OpenRISC patch queue for 2.3
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL 0/2] OpenRISC patch queue for 2.3 |
Date: |
Tue, 3 Feb 2015 13:07:05 +0000 |
On 3 February 2015 at 13:04, Sebastian Macke <address@hidden> wrote:
> Hi Peter,
>
> unfortunately you are right.
>
> The correct line is this:
>
> /* invalidate lock */
> - env->cpu_lock_addr = -1;
> + env->lock_addr = -1;
>
> I am sorry. It was most likely the last line which I added. But I forgot,
> that I disabled the system emulation already.
> Therefore my make process didn't complain.
> Should I send an updated patch, or can you do a hot-fix?
You should send an updated patch, and then Jia needs to re-test
and send a new pull request.
Somebody ought to be testing these instructions in system
emulation mode as well as linux-user...
thanks
-- PMM