qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] This patch hunk will hang scripts/checkpatch.pl...


From: Peter Maydell
Subject: [Qemu-devel] This patch hunk will hang scripts/checkpatch.pl...
Date: Mon, 2 Feb 2015 20:22:43 +0000

The following patch file (a cut down lump of an actual change
I was making) seems to cause scripts/checkpatch.pl to hang.
I find that script too opaque to try to debug, but I post the
offending input here in case anybody else wishes to investigate.

====begin====
commit 4b3cf48c7fa455eb3b31dc844c959964e750a025
Author: Peter Maydell <address@hidden>
Date:   Mon Feb 2 18:47:16 2015 +0000

    This patch will hang checkpatch.pl.

diff --git a/fpu/softfloat.c b/fpu/softfloat.c
index 1110a7e..ab6a93c 100644
@@ -7218,13 +7325,13 @@ static inline int float ## s ##
_compare_internal(float ## s a, float ## s b,\
                                                                              \
 int float ## s ## _compare(float ## s a, float ## s b, float_status *status) \
 {                                                                            \
-    return float ## s ## _compare_internal(a, b, 0 STATUS_VAR);              \
+    return float ## s ## _compare_internal(a, b, 0, status);              \
 }                                                                            \
                                                                              \
 int float ## s ## _compare_quiet(float ## s a, float ## s b,                 \
                                  float_status *status)                       \
 {                                                                            \
-    return float ## s ## _compare_internal(a, b, 1 STATUS_VAR);              \
+    return float ## s ## _compare_internal(a, b, 1, status);              \
 }

 COMPARE(32, 0xff)
====endit====

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]