Re: [Qemu-devel] [PATCH v2 1/4] blockdev: Give find_block_job() an Error ** parameter

[Markus Armbruster]

Max Reitz <address@hidden> writes:

> On 2015-01-29 at 04:36, Markus Armbruster wrote:
>> When find_block_job() fails, all its callers build the same Error
>> object.  Build it in find_block_job() instead.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> Reviewed-by: Eric Blake <address@hidden>
>> ---
>>   blockdev.c | 19 ++++++++-----------
>>   1 file changed, 8 insertions(+), 11 deletions(-)
>
> I think I'd like it better to return "Device not found" in case
> bdrv_find() fails, but that's probably a matter of taste:

Could be done on top.  This patch intentionally doesn't change behavior.

Of course, the whole job thing needs a redesign to liberate it from its
tie to a single BDS.  And then we won't bdrv_find() to find jobs.

> Reviewed-by: Max Reitz <address@hidden>

Thanks!