[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] vnc: fix qemu crash when not configure v
From: |
Don Slutz |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] vnc: fix qemu crash when not configure vnc option |
Date: |
Fri, 30 Jan 2015 08:18:44 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 01/29/15 21:14, address@hidden wrote:
> From: Gonglei <address@hidden>
>
> Add missing vnc options: to, ipv4, ipv6 and fix
> qemu crash.
>
> Reproducer:
> $ x86_64-softmmu/qemu-system-x86_64
> qemu-system-x86_64: Invalid parameter 'to'
> Segmentation fault (core dumped)
>
> BTW the patch fix the below bug:
> https://bugs.launchpad.net/qemu/+bug/1414222
>
> Signed-off-by: Gonglei <address@hidden>
> ---
Looks good,
Reviewed-by: Don Slutz <address@hidden>
-Don Slutz
> ui/vnc.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index a742c90..08b8b24 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -3276,6 +3276,15 @@ static QemuOptsList qemu_vnc_opts = {
> .name = "connections",
> .type = QEMU_OPT_NUMBER,
> },{
> + .name = "to",
> + .type = QEMU_OPT_NUMBER,
> + },{
> + .name = "ipv4",
> + .type = QEMU_OPT_BOOL,
> + },{
> + .name = "ipv6",
> + .type = QEMU_OPT_BOOL,
> + },{
> .name = "password",
> .type = QEMU_OPT_BOOL,
> },{
>