[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v8 04/21] replay: internal functions for rep
From: |
Pavel Dovgaluk |
Subject: |
Re: [Qemu-devel] [RFC PATCH v8 04/21] replay: internal functions for replay log |
Date: |
Fri, 30 Jan 2015 15:56:02 +0300 |
> From: Paolo Bonzini [mailto:address@hidden
> On 22/01/2015 09:51, Pavel Dovgalyuk wrote:
> > This patch adds functions to perform read and write operations
> > with replay log.
> >
> > Signed-off-by: Pavel Dovgalyuk <address@hidden>
> > ---
> > +void replay_check_error(void)
>
> Could this be static? (I haven't checked).
No, because it is used from several replay files.
> > +{
> > + if (replay_file) {
> > + if (feof(replay_file)) {
> > + fprintf(stderr, "replay file is over\n");
> > + exit(1);
>
> Perhaps qemu_system_vmstop_request_prepare +
> qemu_system_vmstop_request(RUN_STATE_PAUSED) instead of exit? Those two
> functions are thread-safe.
There is no need to stop when replay file is over (because we cannot replay
more).
Should we send shutdown request instead?
Pavel Dovgalyuk
- [Qemu-devel] [RFC PATCH v8 01/21] i386: partial revert of interrupt poll fix, (continued)
- [Qemu-devel] [RFC PATCH v8 01/21] i386: partial revert of interrupt poll fix, Pavel Dovgalyuk, 2015/01/22
- [Qemu-devel] [RFC PATCH v8 02/21] replay: global variables and function stubs, Pavel Dovgalyuk, 2015/01/22
- [Qemu-devel] [RFC PATCH v8 03/21] sysemu: system functions for replay, Pavel Dovgalyuk, 2015/01/22
- [Qemu-devel] [RFC PATCH v8 05/21] replay: introduce mutex to protect the replay log, Pavel Dovgalyuk, 2015/01/22
- [Qemu-devel] [RFC PATCH v8 04/21] replay: internal functions for replay log, Pavel Dovgalyuk, 2015/01/22
[Qemu-devel] [RFC PATCH v8 06/21] replay: introduce icount event, Pavel Dovgalyuk, 2015/01/22
[Qemu-devel] [RFC PATCH v8 07/21] cpu-exec: allow temporary disabling icount, Pavel Dovgalyuk, 2015/01/22
[Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence, Pavel Dovgalyuk, 2015/01/22
[Qemu-devel] [RFC PATCH v8 09/21] replay: interrupts and exceptions, Pavel Dovgalyuk, 2015/01/22
[Qemu-devel] [RFC PATCH v8 10/21] replay: asynchronous events infrastructure, Pavel Dovgalyuk, 2015/01/22