qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH v8 18/21] replay: thread pool


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [RFC PATCH v8 18/21] replay: thread pool
Date: Fri, 30 Jan 2015 12:13:55 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0


On 22/01/2015 09:53, Pavel Dovgalyuk wrote:
> -    return thread_pool_submit_aio(pool, aio_worker, acb, cb, opaque);
> +    return thread_pool_submit_aio(pool, aio_worker, acb, cb, opaque,
> +                                  qiov ? qiov->replay : false,
> +                                  qiov ? qiov->replay_step : 0);

Adding the replay/replay_step to the QEMUIOVector is... weird.  You're
paying for the fact that we do not have a BlockRequest struct that is
used throughout.

I guess we can live with this until other problems are solved, then we
can discuss this with the block folks and go for a more complete solution.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]