Re: [Qemu-devel] [PATCH 2/2] bootdevice: add check in restore_boot_order()

[Markus Armbruster]

Gonglei <address@hidden> writes:

> On 2015/1/30 0:03, Alexander Graf wrote:
>
>> 
>> 
>> On 29.01.15 14:29, address@hidden wrote:
>>> From: Gonglei <address@hidden>
>>>
>>> If boot order is invaild or is set failed,
>>> exit qemu.
>>>
>>> Signed-off-by: Gonglei <address@hidden>
>> 
>> Do we really want to kill the machine only because the boot device
>> string doesn't validate?
>> 
>
> Not all of the situation. If people want to change boot order by qmp/hmp
> command, it just report an error, please see do_boot_set(). But if the boot
> order is set in qemu command line, it will exit qemu if the boot device string
> is invalidate, as this patch's situation, which follow the original processing
> way (commit ef3adf68).

I think Alex isn't concerned about the monitor command, but what happens
when boot order "once" is reset to "order" on system reset.

-boot errors should have been detected during command line processing
(strongly preferred) or initial startup (acceptable).  Detecting
configuration errors during operation is nasty.  In cases where we can't
avoid it (and I'm not sure this is one), we need to consider very
carefully whether the error should be fatal.