[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/50] hw/block/fdc: Implement tray status
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 03/50] hw/block/fdc: Implement tray status |
Date: |
Tue, 27 Jan 2015 11:58:06 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 01/26/2015 09:02 AM, Max Reitz wrote:
> The tray of an FDD is open iff there is no medium inserted (there are
> only two states for an FDD: "medium inserted" or "no medium inserted").
>
> This results in the tray being reported as open if qemu has been started
> with the default floppy drive, which breaks some tests. Fix them.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> hw/block/fdc.c | 20 +++++++++++++---
> tests/fdc-test.c | 4 +---
> tests/qemu-iotests/067.out | 60
> +++++++---------------------------------------
> tests/qemu-iotests/071.out | 2 --
> tests/qemu-iotests/081.out | 1 -
> tests/qemu-iotests/087.out | 5 ----
> 6 files changed, 26 insertions(+), 66 deletions(-)
>
> +++ b/hw/block/fdc.c
> @@ -192,6 +192,8 @@ typedef struct FDrive {
> uint8_t ro; /* Is read-only */
> uint8_t media_changed; /* Is media changed */
Might be nice someday to make these bool, but not in this patch.
> uint8_t media_rate; /* Data rate of medium */
> +
> + bool media_inserted; /* Is there a medium in the tray */
> } FDrive;
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 04/50] hw/usb-storage: Check whether BB is inserted, (continued)
- [Qemu-devel] [PATCH 04/50] hw/usb-storage: Check whether BB is inserted, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 08/50] block/quorum: Implement bdrv_is_inserted(), Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 05/50] block: Fix BB AIOCB AioContext without BDS, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 01/50] blockdev: Allow creation of BDS trees without BB, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 03/50] hw/block/fdc: Implement tray status, Max Reitz, 2015/01/26
- Re: [Qemu-devel] [PATCH 03/50] hw/block/fdc: Implement tray status,
Eric Blake <=
- [Qemu-devel] [PATCH 02/50] iotests: Only create BB if necessary, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 13/50] block: Add BlockBackendRootState, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 14/50] block: Make some BB functions fall back to BBRS, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 06/50] block: Add blk_is_available(), Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 12/50] block: Move I/O status and error actions into BB, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 11/50] block: Move BlockAcctStats into BlockBackend, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 07/50] block: Make bdrv_is_inserted() recursive, Max Reitz, 2015/01/26