[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/9] tricore patches
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL 0/9] tricore patches |
Date: |
Tue, 27 Jan 2015 10:40:22 +0000 |
On 26 January 2015 at 20:03, Bastian Koppelmann
<address@hidden> wrote:
> The following changes since commit 1ac0206b2ae1ffaeec564f110664a3a77bafafd2:
>
> qemu-timer.c: Trim list of included headers (2015-01-26 18:15:54 +0000)
>
> are available in the git repository at:
>
> https://github.com/bkoppelmann/qemu-tricore-upstream.git
> tags/pull-tricore20150126-2
>
> for you to fetch changes up to 24c3bf03341ada63a0728f2bdfd2b7c226ad958e:
>
> target-tricore: Add instructions of RRR opcode format (2015-01-26 19:56:46
> +0000)
>
> ----------------------------------------------------------------
> tricore bugfixes and RR1, RR2, RRPW and RRR insn
>
> ----------------------------------------------------------------
Looks like this would introduce a new clang warning:
/home/petmay01/linaro/qemu-for-merges/target-tricore/translate.c:1049:23:
warning: equality
comparison with extraneous parentheses [-Wparentheses-equality]
if ((up_shift == 32)) {
~~~~~~~~~^~~~~
/home/petmay01/linaro/qemu-for-merges/target-tricore/translate.c:1049:23:
note: remove extraneous
parentheses around the comparison to silence this warning
if ((up_shift == 32)) {
~ ^ ~
/home/petmay01/linaro/qemu-for-merges/target-tricore/translate.c:1049:23:
note: use '=' to turn
this equality comparison into an assignment
if ((up_shift == 32)) {
^~
=
We've nearly managed to eradicate all our clang warnings so I
don't want to add more at this point -- could you fix this
and resend the pullreq, please?
thanks
-- PMM
- [Qemu-devel] [PULL 0/9] tricore patches, Bastian Koppelmann, 2015/01/26
- [Qemu-devel] [PULL 1/9] target-tricore: Add missing ULL suffix on 64 bit constant, Bastian Koppelmann, 2015/01/26
- [Qemu-devel] [PULL 6/9] target-tricore: target-tricore: Add instructions of RR1 opcode format, that have 0x93 as first opcode, Bastian Koppelmann, 2015/01/26
- [Qemu-devel] [PULL 3/9] target-tricore: calculate av bits before saturation, Bastian Koppelmann, 2015/01/26
- [Qemu-devel] [PULL 5/9] target-tricore: split up suov32 into suov32_pos and suov32_neg, Bastian Koppelmann, 2015/01/26
- [Qemu-devel] [PULL 7/9] target-tricore: Add instructions of RR2 opcode format, Bastian Koppelmann, 2015/01/26
- [Qemu-devel] [PULL 4/9] target-tricore: Fix bugs found by coverity, Bastian Koppelmann, 2015/01/26
- [Qemu-devel] [PULL 8/9] target-tricore: Add instructions of RRPW opcode format, Bastian Koppelmann, 2015/01/26
- [Qemu-devel] [PULL 9/9] target-tricore: Add instructions of RRR opcode format, Bastian Koppelmann, 2015/01/26
- [Qemu-devel] [PULL 2/9] target-tricore: Several translator and cpu model fixes, Bastian Koppelmann, 2015/01/26
- Re: [Qemu-devel] [PULL 0/9] tricore patches,
Peter Maydell <=