qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 3/4] arm: Add PCIe host bridge in virt machin


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v2 3/4] arm: Add PCIe host bridge in virt machine
Date: Tue, 27 Jan 2015 10:09:26 +0000

On 27 January 2015 at 09:24, Claudio Fontana <address@hidden> wrote:
> On 22.01.2015 16:52, Alexander Graf wrote:
>> On 22.01.15 16:28, Claudio Fontana wrote:
>>> Alex wrote;
>>>> +    for (devfn = 0; devfn <= 0x18; devfn+=0x8) {
>>>
>>> devfn += 0x8 (spaces)
>>
>> Yeah, I had it like that and it looked uglier. I guess it's a matter of
>> personal preference?
>
> You don't have coding standards for this ?

Not formal ones, but (a) I think += should have spaces aronud
it and (b) I'm a bit surprised if checkpatch doesn't catch
this (it certainly attempts to...)

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]