[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 05/21] block: Remove per-BDS close notifiers
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH 05/21] block: Remove per-BDS close notifiers |
Date: |
Mon, 26 Jan 2015 14:27:32 -0500 |
They are unused, and bdrv_close_all() is a perfectly valid replacement.
Signed-off-by: Max Reitz <address@hidden>
---
block.c | 7 -------
block/block-backend.c | 7 -------
include/block/block.h | 1 -
include/block/block_int.h | 2 --
include/sysemu/block-backend.h | 1 -
5 files changed, 18 deletions(-)
diff --git a/block.c b/block.c
index 3adb724..0c6ab96 100644
--- a/block.c
+++ b/block.c
@@ -374,7 +374,6 @@ BlockDriverState *bdrv_new(void)
for (i = 0; i < BLOCK_OP_TYPE_MAX; i++) {
QLIST_INIT(&bs->op_blockers[i]);
}
- notifier_list_init(&bs->close_notifiers);
notifier_with_return_list_init(&bs->before_write_notifiers);
qemu_co_queue_init(&bs->throttled_reqs[0]);
qemu_co_queue_init(&bs->throttled_reqs[1]);
@@ -384,11 +383,6 @@ BlockDriverState *bdrv_new(void)
return bs;
}
-void bdrv_add_close_notifier(BlockDriverState *bs, Notifier *notify)
-{
- notifier_list_add(&bs->close_notifiers, notify);
-}
-
BlockDriver *bdrv_find_format(const char *format_name)
{
BlockDriver *drv1;
@@ -1866,7 +1860,6 @@ void bdrv_close(BlockDriverState *bs)
bdrv_drain_all(); /* complete I/O */
bdrv_flush(bs);
bdrv_drain_all(); /* in case flush left pending I/O */
- notifier_list_notify(&bs->close_notifiers, bs);
if (bs->drv) {
if (bs->backing_hd) {
diff --git a/block/block-backend.c b/block/block-backend.c
index 9f14f9b..b825d8e 100644
--- a/block/block-backend.c
+++ b/block/block-backend.c
@@ -1098,13 +1098,6 @@ void blk_remove_aio_context_notifier(BlockBackend *blk,
}
}
-void blk_add_close_notifier(BlockBackend *blk, Notifier *notify)
-{
- if (blk->bs) {
- bdrv_add_close_notifier(blk->bs, notify);
- }
-}
-
void blk_io_plug(BlockBackend *blk)
{
if (blk->bs) {
diff --git a/include/block/block.h b/include/block/block.h
index 301baac..2b7b3d6 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -192,7 +192,6 @@ int bdrv_reopen_prepare(BDRVReopenState *reopen_state,
void bdrv_reopen_commit(BDRVReopenState *reopen_state);
void bdrv_reopen_abort(BDRVReopenState *reopen_state);
void bdrv_close(BlockDriverState *bs);
-void bdrv_add_close_notifier(BlockDriverState *bs, Notifier *notify);
int bdrv_read(BlockDriverState *bs, int64_t sector_num,
uint8_t *buf, int nb_sectors);
int bdrv_read_unthrottled(BlockDriverState *bs, int64_t sector_num,
diff --git a/include/block/block_int.h b/include/block/block_int.h
index 91d21c5..9842655 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -350,8 +350,6 @@ struct BlockDriverState {
BlockDriverState *backing_hd;
BlockDriverState *file;
- NotifierList close_notifiers;
-
/* Callback before write request is processed */
NotifierWithReturnList before_write_notifiers;
diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h
index 12a05df..f1da495 100644
--- a/include/sysemu/block-backend.h
+++ b/include/sysemu/block-backend.h
@@ -159,7 +159,6 @@ void blk_remove_aio_context_notifier(BlockBackend *blk,
void *),
void (*detach_aio_context)(void *),
void *opaque);
-void blk_add_close_notifier(BlockBackend *blk, Notifier *notify);
void blk_io_plug(BlockBackend *blk);
void blk_io_unplug(BlockBackend *blk);
BlockAcctStats *blk_get_stats(BlockBackend *blk);
--
2.1.0
- Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers, (continued)
- Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers, Paolo Bonzini, 2015/01/26
- Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers, Max Reitz, 2015/01/26
- Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers, Paolo Bonzini, 2015/01/26
- Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers, Max Reitz, 2015/01/26
- Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers, Paolo Bonzini, 2015/01/26
- Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers, Eric Blake, 2015/01/28
- Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers, Max Reitz, 2015/01/28
- Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers, Paolo Bonzini, 2015/01/29
Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers, Eric Blake, 2015/01/28
[Qemu-devel] [PATCH 05/21] block: Remove per-BDS close notifiers,
Max Reitz <=
[Qemu-devel] [PATCH 10/21] block: Add blk_next_inserted(), Max Reitz, 2015/01/26
[Qemu-devel] [PATCH 02/21] quorum: Fix close path, Max Reitz, 2015/01/26
[Qemu-devel] [PATCH 14/21] blockdev: Remove blk_hide_on_behalf_of_do_drive_del(), Max Reitz, 2015/01/26
[Qemu-devel] [PATCH 16/21] block: Move some bdrv_*_all() functions to BB, Max Reitz, 2015/01/26
[Qemu-devel] [PATCH 12/21] block: Use BlockBackend more, Max Reitz, 2015/01/26