[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 11/11] hw/arm/virt: Enable dynamic generatio
From: |
Shannon Zhao |
Subject: |
Re: [Qemu-devel] [RFC PATCH 11/11] hw/arm/virt: Enable dynamic generation of ACPI v5.1 tables |
Date: |
Mon, 26 Jan 2015 09:59:57 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 2015/1/25 2:56, Laszlo Ersek wrote:
> On 01/24/15 10:21, Shannon Zhao wrote:
>> Expose the needed device information to the table generation
>> insfrastructure and register a machine_init_done notify to
>> call virt_acpi_build().
>>
>> Add CONFIG_ACPI to arm-softmmu.mak, but there is compile error.
>> Don't include unnecessary file for ARM. Maybe this way is not
>> right, fix me please.
>>
>> Signed-off-by: Shannon Zhao <address@hidden>
>> ---
>> default-configs/arm-softmmu.mak | 1 +
>> default-configs/i386-softmmu.mak | 3 ++
>> default-configs/mips-softmmu.mak | 3 ++
>> default-configs/mips64-softmmu.mak | 3 ++
>> default-configs/mips64el-softmmu.mak | 3 ++
>> default-configs/mipsel-softmmu.mak | 3 ++
>> default-configs/x86_64-softmmu.mak | 3 ++
>> hw/acpi/Makefile.objs | 5 ++-
>> hw/arm/virt.c | 59
>> +++++++++++++++++++++++++++++++--
>> hw/i2c/Makefile.objs | 2 +-
>> 10 files changed, 78 insertions(+), 7 deletions(-)
>
>> diff --git a/hw/acpi/Makefile.objs b/hw/acpi/Makefile.objs
>> index cad0355..4e3f15f 100644
>> --- a/hw/acpi/Makefile.objs
>> +++ b/hw/acpi/Makefile.objs
>> @@ -1,5 +1,6 @@
>> -common-obj-$(CONFIG_ACPI) += core.o piix4.o ich9.o pcihp.o cpu_hotplug.o
>> -common-obj-$(CONFIG_ACPI) += memory_hotplug.o
>> +common-obj-$(CONFIG_ACPI_CORE) += core.o piix4.o ich9.o pcihp.o
>> +common-obj-$(CONFIG_ACPI_HOTPLUG) += cpu_hotplug.o
>
> This line has a typo and it breaks the linking of qemu-system-x86_64.
> You need to say
>
> CONFIG_ACPI_CPU_HOTPLUG
>
> here, not
>
> CONFIG_ACPI_HOTPLUG
>
Laszlo, Thanks. Will fix this.
Thanks,
Shannon
- Re: [Qemu-devel] [RFC PATCH 09/11] hw/acpi/acpi-build-utils: Add acpi_fixed_memory32() and acpi_extended_irq(), (continued)
- [Qemu-devel] [RFC PATCH 04/11] hw/arm/virt-acpi-build: Generate XSDT table and add a build_header function, Shannon Zhao, 2015/01/24
- [Qemu-devel] [RFC PATCH 10/11] hw/arm/virt-acpi-build: Generation of DSDT table for virt devices, Shannon Zhao, 2015/01/24
- [Qemu-devel] [RFC PATCH 08/11] hw/arm/virt-acpi-build: Generate FACS table and update ACPI headers, Shannon Zhao, 2015/01/24
- [Qemu-devel] [RFC PATCH 11/11] hw/arm/virt: Enable dynamic generation of ACPI v5.1 tables, Shannon Zhao, 2015/01/24
- [Qemu-devel] [RFC PATCH 03/11] hw/arm/virt-acpi-build: Generate RSDP table, Shannon Zhao, 2015/01/24
- [Qemu-devel] [RFC PATCH 01/11] hw/i386: Move ACPI header definitions in an arch-independent location, Shannon Zhao, 2015/01/24
- [Qemu-devel] [RFC PATCH 07/11] hw/arm/virt-acpi-build: Generate FADT table and update ACPI headers, Shannon Zhao, 2015/01/24
- [Qemu-devel] [RFC PATCH 05/11] hw/arm/virt-acpi-build: Generate MADT table, Shannon Zhao, 2015/01/24