Re: [Qemu-devel] [PATCH v2] alt-gr on Windows

[Thebault, Remi]

Hello

attached is the v2 set of patchs.

Le 01/01/2015 20:10, Stefan Weil a écrit :
> I suggest calling MapVirtualKey only for those keys which don't need special 
> handling, so it would be in the default case of the switch statement.
Done (patch 0001) . updated code yields to same result as previous patch. Added 
a FIXME note regarding the previous alt gr fix, which do not look relevant 
anymore to me.

> It looks like Alt-Ctrl is a valid alternative for pressing AltGr on Windows, 
> so we have to take that into account, too.
Few tests I did on a XP vm give correct keyboard behaviour. looks like this is 
transparent on Windows guest.

> Wine also needs special handling because it sends a single (different) key 
> code instead of two key codes.
By this I understand that Wine should just be excluded from this fix (what I do 
by patch 0002)

Regards,
Rémi

0001-input-gtk-win32-ui-sends-r-ctrl-and-r-alt-key-events.patch
Description: Text document

0002-input-introduce-INPUT_NEEDS_ALTGR_FIX-macro.patch
Description: Text document

0003-input-gtk-win32-ui-handles-altgr-key-correctly.patch
Description: Text document

0004-input-sdl2-win32-ui-handles-altgr-key-correctly.patch
Description: Text document