[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/13] migration: Add a new feature to do live
From: |
Li, Liang Z |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/13] migration: Add a new feature to do live migration |
Date: |
Sat, 24 Jan 2015 13:25:04 +0000 |
Thanks Dave & Eric for spending time to review my patches and giving the
valuable comments, I will refine my patches in the later version according
to your suggestions.
> * Liang Li (address@hidden) wrote:
> > This feature can help to reduce the data transferred about 60%, and
> > the migration time can also be reduced about 70%.
> >
> > Summary of changed from v2->v3
> >
> > -Splited the patch to 13 parts instead of 2
> > -Rewrote the core code to do compression and decompression
> > -Updated the document
> > -Added a common command interface to set and query parameters
> > -Added some comments
>
> Hi,
> Apologies for taking so long; generally this is a lot nicer.
> I'll reply to each patch individually, but two more general questions:
> a) Shouldn't compressBound be used somewhere to get the worst case
> compressed size?
Yes, compressBound is better to deal with the worst case, I will make a change.
> b) I think adding some trace points would be useful; it would make it
> easier
> to
> spot when you were waiting for threads etc.
>
I will do that.
Liang