Re: [Qemu-devel] [PATCH] fix QEMU build on Xen/ARM

[Stefano Stabellini]

On Thu, 22 Jan 2015, Don Slutz wrote:
> On 01/22/15 13:46, Stefano Stabellini wrote:
> > xen_get_vmport_regs_pfn should take a xen_pfn_t argument, not an
> > unsigned long argument (in fact xen_pfn_t is defined as uint64_t on
> > ARM).
> > 
> > Also use xc_hvm_param_get instead of the deprecated xc_get_hvm_param.
> > 
> > Signed-off-by: Stefano Stabellini <address@hidden>
> > 
> > diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h
> > index 519696f..355fbac 100644
> > --- a/include/hw/xen/xen_common.h
> > +++ b/include/hw/xen/xen_common.h
> > @@ -168,14 +168,16 @@ void xen_shutdown_fatal_error(const char *fmt, ...) 
> > GCC_FMT_ATTR(1, 2);
> >  
> >  #ifdef HVM_PARAM_VMPORT_REGS_PFN
> >  static inline int xen_get_vmport_regs_pfn(XenXC xc, domid_t dom,
> > -                                          unsigned long *vmport_regs_pfn)
> > +                                          xen_pfn_t *vmport_regs_pfn)
> >  {
> > -    return xc_get_hvm_param(xc, dom, HVM_PARAM_VMPORT_REGS_PFN,
> > -                            vmport_regs_pfn);
> > +    uint64_t value;
> > +    return xc_hvm_param_get(xc, dom, HVM_PARAM_VMPORT_REGS_PFN,
> > +                            &value);
> 
> This is not going to work.  Maybe "int rc =" instead of return?
> 
> (See if if this time the reply is not a big mess.)
>     -Don Slutz

/me shakes his heads in shame

You are right, I'll fix it and resend.

> > +    *vmport_regs_pfn = (xen_pfn_t) value;
> >  }
> >  #else
> >  static inline int xen_get_vmport_regs_pfn(XenXC xc, domid_t dom,
> > -                                          unsigned long *vmport_regs_pfn)
> > +                                          xen_pfn_t *vmport_regs_pfn)
> >  {
> >      return -ENOSYS;
> >  }
> > 
> > 
>