[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3 V3] s390: implement pci instructions
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH 2/3 V3] s390: implement pci instructions |
Date: |
Tue, 20 Jan 2015 11:03:48 +0100 |
On Tue, 20 Jan 2015 10:45:41 +0100
Markus Armbruster <address@hidden> wrote:
> This patch makes Coverity unhappy:
>
> *** CID 1264326: Unintended sign extension (SIGN_EXTENSION)
> /hw/s390x/s390-pci-inst.c: 787 in stpcifc_service_call()
> 781 stq_p(&fib.pal, pbdev->pal);
> 782 stq_p(&fib.iota, pbdev->g_iota);
> 783 stq_p(&fib.aibv, pbdev->routes.adapter.ind_addr);
> 784 stq_p(&fib.aisb, pbdev->routes.adapter.summary_addr);
> 785 stq_p(&fib.fmb_addr, pbdev->fmb_addr);
> 786
> >>> CID 1264326: Unintended sign extension (SIGN_EXTENSION)
> >>> Suspicious implicit sign extension: "pbdev->isc" with type
> >>> "unsigned char" (8 bits, unsigned) is promoted in "(pbdev->isc <<
> >>> 28) | (pbdev->noi << 16)" to type "int" (32 bits, signed), then
> >>> sign-extended to type "unsigned long" (64 bits, unsigned). If
> >>> "(pbdev->isc << 28) | (pbdev->noi << 16)" is greater than
> >>> 0x7FFFFFFF, the upper bits of the result will all be 1.
> 787 data = (pbdev->isc << 28) | (pbdev->noi << 16) |
> 788 (pbdev->routes.adapter.ind_offset << 8) | (pbdev->sum <<
> 7) |
> 789 pbdev->routes.adapter.summary_offset;
> 790 stw_p(&fib.data, data);
> 791
> 792 if (pbdev->fh >> ENABLE_BIT_OFFSET) {
There's a fix for this (and the memory leak):
http://marc.info/?l=qemu-devel&m=142124886620078&w=2
The patch is sitting in my queue, will send with the next pile of s390x
updates.
- [Qemu-devel] [PATCH 0/3 V3] add PCI support for the s390 platform, Frank Blaschka, 2015/01/09
- [Qemu-devel] [PATCH 3/3 V3] kvm: extend kvm_irqchip_add_msi_route to work on s390, Frank Blaschka, 2015/01/09
- [Qemu-devel] [PATCH 2/3 V3] s390: implement pci instructions, Frank Blaschka, 2015/01/09
- Re: [Qemu-devel] [PATCH 2/3 V3] s390: implement pci instructions, Markus Armbruster, 2015/01/20
- Re: [Qemu-devel] [PATCH 2/3 V3] s390: implement pci instructions,
Cornelia Huck <=
- Re: [Qemu-devel] [PATCH 2/3 V3] s390: implement pci instructions, Markus Armbruster, 2015/01/20
- Re: [Qemu-devel] [PATCH 2/3 V3] s390: implement pci instructions, Markus Armbruster, 2015/01/20
- Re: [Qemu-devel] [PATCH 2/3 V3] s390: implement pci instructions, Frank Blaschka, 2015/01/20
- Re: [Qemu-devel] [PATCH 2/3 V3] s390: implement pci instructions, Markus Armbruster, 2015/01/20
- Re: [Qemu-devel] [PATCH 2/3 V3] s390: implement pci instructions, Markus Armbruster, 2015/01/21
- Re: [Qemu-devel] [PATCH 2/3 V3] s390: implement pci instructions, Peter Maydell, 2015/01/21
- Re: [Qemu-devel] [PATCH 2/3 V3] s390: implement pci instructions, Markus Armbruster, 2015/01/21
- Re: [Qemu-devel] [PATCH 2/3 V3] s390: implement pci instructions, Peter Maydell, 2015/01/21
- Re: [Qemu-devel] [PATCH 2/3 V3] s390: implement pci instructions, Paolo Bonzini, 2015/01/21
- Re: [Qemu-devel] [PATCH 2/3 V3] s390: implement pci instructions, Cornelia Huck, 2015/01/21