qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Add trace messages to input.c.


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH] Add trace messages to input.c.
Date: Mon, 19 Jan 2015 08:34:22 +0100

On Fr, 2015-01-16 at 14:08 -0500, Don Koch wrote:
> Signed-off-by: Don Koch <address@hidden>

> +    trace_do_mouse_set(mon, index);

First, I think we should have a better name for that one, maybe
"input_mouse_set" ?

Second I'm wondering what the use case is.  The place is a bit strange
(tracing management not guest behavior), also all the existing input
trace points log the device index so you can already see how the events
are routed ...

cheers,
  Gerd





reply via email to

[Prev in Thread] Current Thread [Next in Thread]