[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 14/16] qed: check for header size overflow
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL 14/16] qed: check for header size overflow |
Date: |
Fri, 16 Jan 2015 15:37:11 +0000 |
Header size is denoted in clusters. The maximum cluster size is 64 MB
but there is no limit on header size. Check for uint32_t overflow in
case the header size field has a whacky value.
Signed-off-by: Stefan Hajnoczi <address@hidden>
Message-id: address@hidden
Reviewed-by: Kevin Wolf <address@hidden>
---
block/qed.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/block/qed.c b/block/qed.c
index 80f18d8..892b13c 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -440,6 +440,11 @@ static int bdrv_qed_open(BlockDriverState *bs, QDict
*options, int flags,
s->l2_mask = s->table_nelems - 1;
s->l1_shift = s->l2_shift + ffs(s->table_nelems) - 1;
+ /* Header size calculation must not overflow uint32_t */
+ if (s->header.header_size > UINT32_MAX / s->header.cluster_size) {
+ return -EINVAL;
+ }
+
if ((s->header.features & QED_F_BACKING_FILE)) {
if ((uint64_t)s->header.backing_filename_offset +
s->header.backing_filename_size >
--
2.1.0
- [Qemu-devel] [PULL 02/16] block/dmg: properly detect the UDIF trailer, (continued)
- [Qemu-devel] [PULL 02/16] block/dmg: properly detect the UDIF trailer, Stefan Hajnoczi, 2015/01/16
- [Qemu-devel] [PULL 03/16] block/dmg: extract mish block decoding functionality, Stefan Hajnoczi, 2015/01/16
- [Qemu-devel] [PULL 04/16] block/dmg: extract processing of resource forks, Stefan Hajnoczi, 2015/01/16
- [Qemu-devel] [PULL 07/16] block/dmg: process XML plists, Stefan Hajnoczi, 2015/01/16
- [Qemu-devel] [PULL 05/16] block/dmg: process a buffer instead of reading ints, Stefan Hajnoczi, 2015/01/16
- [Qemu-devel] [PULL 06/16] block/dmg: validate chunk size to avoid overflow, Stefan Hajnoczi, 2015/01/16
- [Qemu-devel] [PULL 10/16] block/dmg: use SectorNumber from BLKX header, Stefan Hajnoczi, 2015/01/16
- [Qemu-devel] [PULL 08/16] block/dmg: set virtual size to a non-zero value, Stefan Hajnoczi, 2015/01/16
- [Qemu-devel] [PULL 12/16] block/dmg: support bzip2 block entry types, Stefan Hajnoczi, 2015/01/16
- [Qemu-devel] [PULL 09/16] block/dmg: fix sector data offset calculation, Stefan Hajnoczi, 2015/01/16
- [Qemu-devel] [PULL 14/16] qed: check for header size overflow,
Stefan Hajnoczi <=
- [Qemu-devel] [PULL 11/16] block/dmg: factor out block type check, Stefan Hajnoczi, 2015/01/16
- [Qemu-devel] [PULL 15/16] qemu-iotests: add 116 invalid QED input file tests, Stefan Hajnoczi, 2015/01/16
- [Qemu-devel] [PULL 13/16] block/dmg: improve zeroes handling, Stefan Hajnoczi, 2015/01/16
- [Qemu-devel] [PULL 16/16] qemu-iotests: Fix supported_oses check, Stefan Hajnoczi, 2015/01/16
- Re: [Qemu-devel] [PULL 00/16] Block patches, Peter Maydell, 2015/01/16