Re: [Qemu-devel] [PATCH v3 4/5] Split the QEMU buffered file code out

[Stefan Berger]

On 12/18/2014 04:24 AM, Dr. David Alan Gilbert wrote:
> * David Gibson (address@hidden) wrote:
> > On Fri, Dec 12, 2014 at 11:13:41AM +0000, Dr. David Alan Gilbert (git) wrote:
> > > From: "Dr. David Alan Gilbert" <address@hidden>
> > >
> > > The splitting of qemu-file and addition of the buffered file landed
> > > at the same time; so now split the buffered file code out.
> > >
> > > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> > > ---
> > >   migration/Makefile.objs   |   2 +-
> > >   migration/qemu-file-buf.c | 486 ++++++++++++++++++++++++++++++++++++++++++++++
> > >   migration/qemu-file.c     | 455 -------------------------------------------
> > >   tests/Makefile            |   3 +-
> > >   4 files changed, 489 insertions(+), 457 deletions(-)
> > >   create mode 100644 migration/qemu-file-buf.c
> > >
> > > diff --git a/migration/Makefile.objs b/migration/Makefile.objs
> > > index ce1e3c7..d929e96 100644
> > > --- a/migration/Makefile.objs
> > > +++ b/migration/Makefile.objs
> > > @@ -1,6 +1,6 @@
> > >   common-obj-y += migration.o tcp.o
> > >   common-obj-y += vmstate.o
> > > -common-obj-y += qemu-file.o qemu-file-unix.o qemu-file-stdio.o
> > > +common-obj-y += qemu-file.o qemu-file-buf.o qemu-file-unix.o qemu-file-stdio.o
> > >   common-obj-y += xbzrle.o
> > >   
> > >   common-obj-$(CONFIG_RDMA) += rdma.o
> > > diff --git a/migration/qemu-file-buf.c b/migration/qemu-file-buf.c
> > > new file mode 100644
> > > index 0000000..d33dd44
> > > --- /dev/null
> > > +++ b/migration/qemu-file-buf.c
> > > @@ -0,0 +1,486 @@
> > > +/*
> > > + * QEMU System Emulator
> > > + *
> > > + * Copyright (c) 2003-2008 Fabrice Bellard
> > Bit hard to believe that only Fabrice listed on this file is correct,
> > given the buffered file stuff is fairly new.
> Yes, I'd be happy to add Stefan and Joel's name to that, although
> they never added it in their original patch, and when splitting files
> we do normally take the copyright header from what we split out of;
> but you are right it's misleading.

I'll add IBM as an additional copyright holder to the qemu-file-buf.c 
and myself as an author. Whoever else wants to be added as an author, 
either let me know or submit a patch.

   Stefan