[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/15] monitor.c: Use ld*_p() instead of ld*_raw
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH 02/15] monitor.c: Use ld*_p() instead of ld*_raw() |
Date: |
Thu, 15 Jan 2015 15:54:32 +0000 |
Peter Maydell <address@hidden> writes:
> The monitor code for doing a memory_dump() was using ld*_raw() to do
> target-CPU accesses out of a local buf[] array. The correct functions
> for this purpose are ld*_p(), which take a host pointer, rather than
> ld*_raw(), which take an integer representing a guest address and
> are somewhat meaningless in softmmu configurations. Nobody noticed
> because for softmmu the _raw functions are the same as ldl_p but
> with some extra casts thrown in. Switch to using the correct functions
> instead.
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> monitor.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index 1808e41..7e4f605 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -1292,16 +1292,16 @@ static void memory_dump(Monitor *mon, int count, int
> format, int wsize,
> switch(wsize) {
> default:
> case 1:
> - v = ldub_raw(buf + i);
> + v = ldub_p(buf + i);
> break;
> case 2:
> - v = lduw_raw(buf + i);
> + v = lduw_p(buf + i);
> break;
> case 4:
> - v = (uint32_t)ldl_raw(buf + i);
> + v = (uint32_t)ldl_p(buf + i);
> break;
> case 8:
> - v = ldq_raw(buf + i);
> + v = ldq_p(buf + i);
> break;
> }
> monitor_printf(mon, " ");
--
Alex Bennée
- [Qemu-devel] [PATCH 01/15] cpu_ldst.h: Remove unused ldul_ macros, (continued)
- [Qemu-devel] [PATCH 01/15] cpu_ldst.h: Remove unused ldul_ macros, Peter Maydell, 2015/01/15
- [Qemu-devel] [PATCH 14/15] cpu_ldst_template.h: Drop unused cpu_ldfq/stfq/ldfl/stfl accessors, Peter Maydell, 2015/01/15
- [Qemu-devel] [PATCH 08/15] target-mips: Don't use _raw load/store accessors, Peter Maydell, 2015/01/15
- [Qemu-devel] [PATCH 09/15] cpu_ldst.h: Drop unused ld/st*_kernel defines, Peter Maydell, 2015/01/15
- [Qemu-devel] [PATCH 15/15] cpu_ldst.h, cpu-all.h, bswap.h: Update documentation on ld/st accessors, Peter Maydell, 2015/01/15
- [Qemu-devel] [PATCH 07/15] linux-user/main.c (m68k): Use get_user_u16 rather than lduw in cpu_loop, Peter Maydell, 2015/01/15
- [Qemu-devel] [PATCH 05/15] bsd-user/elfload.c: Don't use ldl() or ldq_raw(), Peter Maydell, 2015/01/15
- [Qemu-devel] [PATCH 02/15] monitor.c: Use ld*_p() instead of ld*_raw(), Peter Maydell, 2015/01/15
- Re: [Qemu-devel] [PATCH 02/15] monitor.c: Use ld*_p() instead of ld*_raw(),
Alex Bennée <=
- [Qemu-devel] [PATCH 04/15] linux-user/elfload.c: Don't use _raw accessor functions, Peter Maydell, 2015/01/15
- Re: [Qemu-devel] [PATCH 00/15] Clean up cpu-ldst ld/st memory accessors, Lluís Vilanova, 2015/01/15
- Re: [Qemu-devel] [PATCH 00/15] Clean up cpu-ldst ld/st memory accessors, Richard Henderson, 2015/01/16