Re: [Qemu-devel] [PATCH] Fixes several full screen issues on Mac OS X

[Peter Maydell]

On 14 January 2015 at 18:59, Programmingkid <address@hidden> wrote:
>
> On Jan 14, 2015, at 1:29 PM, Peter Maydell wrote:
>
>> On 14 January 2015 at 18:18, Programmingkid <address@hidden> wrote:
>>>
>>> On Jan 14, 2015, at 12:19 PM, Peter Maydell wrote:
>>>> (2) Having done this I find that all my other application windows
>>>> have been squashed down into a corner of my screen, presumably because
>>>> we've told MacOSX "the screen is 640x480" and it's rearranged the
>>>> app windows to suit. We mustn't mess things up like this.
>>>
>>> This can't be avoided. When the screen resolution changes, all the
>>> applications usually adjust to the new size. It is the same thing
>>> that happens when you use a full screen game.
>>
>> No, when I use other full screen programs this doesn't happen at all.
>> QEMU with this patch is the first time I've ever seen this from
>> any OSX app.
>
> How long have you been a Mac user? I am shocked you have never seen
> this before. I'm guessing full screen gaming was never your thing.

Three years or so. I don't do much full screen stuff but I have
played a few games that fullscreen. In any case I think the
behaviour is definitely not something we can accept.

>> The point is that you've dropped a bugfix which isn't related to
>> full screen at all -- if this is the first call to switchSurface
>> we *must* display it, which is what the cdx check does. See
>> commit 381600dad.

> This bugfix does change the appearance of full screen mode.
> Have you seen a guest at full screen? The cdx and cdy variables
> make the guest OS look very distorted.

For me with current trunk the fullscreen is just "usual display,
not expanded at all, as only thing on the screen". Regardless,
this code your patch deletes was added *to fix a bug* and you
cannot simply delete it because it happens to get in the way of
a different fix you want to make. You must come up with something
that fixes both problems.

-- PMM