[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] target-i386: do not memcpy in and out of xm
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/4] target-i386: do not memcpy in and out of xmm_regs |
|
Date: |
Tue, 13 Jan 2015 20:49:59 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 13/01/2015 19:37, Eduardo Habkost wrote:
>> > + tcg_gen_ld_i64(cpu_tmp1_i64, cpu_env, s_offset + offsetof(XMMReg,
>> > XMM_Q(1));
>> > + tcg_gen_st_i64(cpu_tmp1_i64, cpu_env, d_offset + offsetof(XMMReg,
>> > XMM_Q(1));
> It looks good (I even sent my Reviewed-by line), but:
>
> target-i386/translate.c:2624:88: error: expected ‘)’ before ‘;’ token
> tcg_gen_ld_i64(cpu_tmp1_i64, cpu_env, s_offset + offsetof(XMMReg,
> XMM_Q(0));
>
> ^
This sounds familiar. I had attached the wrong version of the series,
but the only difference is the two extra parentheses.
Paolo
- Re: [Qemu-devel] [PATCH 1/4] target-i386: fix movntsd on big-endian hosts, (continued)
[Qemu-devel] [PATCH 4/4] target-i386: make xmm_regs 512-bit wide, Paolo Bonzini, 2015/01/07
[Qemu-devel] [PATCH 2/4] target-i386: do not memcpy in and out of xmm_regs, Paolo Bonzini, 2015/01/07
[Qemu-devel] [PATCH 3/4] target-i386: use vmstate_offset_sub_array for AVX registers, Paolo Bonzini, 2015/01/07