Re: [Qemu-devel] [PATCH 1/8] tls: require compiler support for __thread

[Peter Maydell]

On 13 January 2015 at 17:52, Paolo Bonzini <address@hidden> wrote:
> The block layer is now using __thread unconditionally.

Where? I did a quick grep for __thread and (other than stuff in
the *-user code and some Win32 specific files) there's no use of
__thread outside the DEFINE_TLS wrappers.

>  Remove the
> "fake" TLS wrappers (that actually aren't TLS on !Linux) in
> include/qemu/tls.h, and add a testcase.

What platforms have you tested on? We definitely shouldn't
widen our use of __thread without testing it on all the
platforms we support...

thanks
-- PMM