qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH v7 12/21] replay: recording and replaying cl

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [RFC PATCH v7 12/21] replay: recording and replaying clock ticks
Date: Mon, 12 Jan 2015 13:45:19 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 

On 12/01/2015 13:43, Pavel Dovgaluk wrote:
>>> > > +#define REPLAY_CLOCK(clock, value)                                     
>>> > >  \
>>> > > +    (replay_mode == REPLAY_MODE_PLAY ? replay_read_clock((clock))      
>>> > >  \
>>> > > +        : replay_mode == REPLAY_MODE_RECORD                            
>>> > >  \
>>> > > +            ? replay_save_clock((clock), (value))                      
>>> > >  \
>>> > > +        : (value))
>>> > > +
>> > 
>> > Inline functions please, not macros.
> Macro is required here, because I do not want the "value" to be computed in
> replay mode at all.

Indeed you're right.

Paolo
reply via email to
[Prev in Thread] Current Thread [Next in Thread]