[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v7 02/21] replay: global variables and funct
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH v7 02/21] replay: global variables and function stubs |
|
Date: |
Mon, 12 Jan 2015 13:25:50 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 12/01/2015 13:21, Pavel Dovgaluk wrote:
>>> > > +{ 'enum': 'ReplaySubmode',
>>> > > + 'data': [ 'unknown', 'normal' ] }
>> >
>> > What is a submode? Can you just check if replay_file is NULL?
> Submode is not very useful for these core patches.
> More submodes will be introduces in reverse debugging patches.
I see. For now, can you replace it with just a replay_file check, and
move this definition to the reverse debugging patches?
Paolo
- [Qemu-devel] [RFC PATCH v7 00/21] Deterministic replay core, Pavel Dovgalyuk, 2015/01/12
- [Qemu-devel] [RFC PATCH v7 03/21] sysemu: system functions for replay, Pavel Dovgalyuk, 2015/01/12
- [Qemu-devel] [RFC PATCH v7 04/21] replay: internal functions for replay log, Pavel Dovgalyuk, 2015/01/12
- [Qemu-devel] [RFC PATCH v7 05/21] replay: introduce icount event, Pavel Dovgalyuk, 2015/01/12
- [Qemu-devel] [RFC PATCH v7 07/21] cpu: replay instructions sequence, Pavel Dovgalyuk, 2015/01/12
- [Qemu-devel] [RFC PATCH v7 06/21] cpu-exec: allow temporary disabling icount, Pavel Dovgalyuk, 2015/01/12
- [Qemu-devel] [RFC PATCH v7 08/21] replay: interrupts and exceptions, Pavel Dovgalyuk, 2015/01/12