[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu_opt_get_bool_helper: Fix option handling
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] qemu_opt_get_bool_helper: Fix option handling |
Date: |
Thu, 08 Jan 2015 09:39:48 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 01/08/2015 09:09 AM, Michal Privoznik wrote:
> Well, after 49d2e648e8087 the options to -machine parameter no longer
> has .desc nor .desc->type. That's mainly because the options are
> dynamically added while .desc is allocated statically. Anyway, if user
> tries to run:
>
> qemu-system-x86_64 -machine pc-i440fx-2.2,accel=kvm,usb=off
>
> the arguments evaluation fails with:
>
> qemu_opt_get_bool_helper: Assertion `opt->desc && opt->desc->type ==
> QEMU_OPT_BOOL' failed.
>
> Fix this by dropping the assert() which is useless after the mentioned
> commit anyway.
>
> Signed-off-by: Michal Privoznik <address@hidden>
> ---
> util/qemu-option.c | 1 -
> 1 file changed, 1 deletion(-)
There are several other open threads about this same issue. The
consensus so far appears to be that the assert is catching a real bug,
and should remain, and that we are instead working on the patches to fix
the real bug.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature