Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

[Javier Celaya]

Sure, for the help text of the image-compression option, thanks.

El Jueves, 8 de enero de 2015 12:48:57 Fabio Fantoni escribió:
> Il 08/01/2015 11:50, Javier Celaya ha scritto:
> > Hello
> > 
> > Recently, SPICE included the lz4 compression algorithm. This patch adds
> > a command line option to select it. However, SPICE_IMAGE_COMPRESS_LZ4 did
> > not exist before the commit that added this compression algorithm, so it
> > should be guarded with conditional compilation. How do you think this
> > should be done? Wait for the next stable version of spice-server and
> > check for
> > SPICE_SERVER_VERSION? Or add a specific flag?
> > 
> > Thank you
> > ---
> > 
> >  ui/spice-core.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/ui/spice-core.c b/ui/spice-core.c
> > index 6467fa4..fb6534e 100644
> > --- a/ui/spice-core.c
> > +++ b/ui/spice-core.c
> > @@ -359,6 +359,7 @@ static const char *compression_names[] = {
> > 
> >      [ SPICE_IMAGE_COMPRESS_QUIC ]     = "quic",
> >      [ SPICE_IMAGE_COMPRESS_GLZ ]      = "glz",
> >      [ SPICE_IMAGE_COMPRESS_LZ ]       = "lz",
> > 
> > +    [ SPICE_IMAGE_COMPRESS_LZ4 ]      = "lz4",
> > 
> >  };
> >  #define parse_compression(_name)                                        \
> >  
> >      parse_name(_name, "image compression",                              \
> > 
> > --
> > 1.9.3
> 
> I did a small search now and seems that also other small change to
> qemu-options.hx file should be done, search this line:
> @item image-compression=[auto_glz|auto_lz|quic|glz|lz|off]
> 
> > _______________________________________________
> > Spice-devel mailing list
> > address@hidden
> > http://lists.freedesktop.org/mailman/listinfo/spice-devel