[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v6 03/11] fw_cfg_mem: max access size and region siz
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH v6 03/11] fw_cfg_mem: max access size and region size are the same for data register |
Date: |
Mon, 22 Dec 2014 13:11:37 +0100 |
From: Laszlo Ersek <address@hidden>
Make it clear that the maximum access size to the MMIO data register
determines the full size of the memory region.
Currently the max access size is 1.
This patch doesn't change behavior.
Signed-off-by: Laszlo Ersek <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/nvram/fw_cfg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index c48bc6e..8deb860 100644
--- a/hw/nvram/fw_cfg.c
+++ b/hw/nvram/fw_cfg.c
@@ -31,7 +31,6 @@
#include "qemu/config-file.h"
#define FW_CFG_SIZE 2
-#define FW_CFG_DATA_SIZE 1
#define FW_CFG_NAME "fw_cfg"
#define FW_CFG_PATH "/machine/" FW_CFG_NAME
@@ -694,7 +693,8 @@ static void fw_cfg_mem_realize(DeviceState *dev, Error
**errp)
sysbus_init_mmio(sbd, &s->ctl_iomem);
memory_region_init_io(&s->data_iomem, OBJECT(s), &fw_cfg_data_mem_ops,
- FW_CFG(s), "fwcfg.data", FW_CFG_DATA_SIZE);
+ FW_CFG(s), "fwcfg.data",
+ fw_cfg_data_mem_ops.valid.max_access_size);
sysbus_init_mmio(sbd, &s->data_iomem);
}
--
2.1.0
- [Qemu-devel] [PATCH v6 00/11] fw_cfg, bootorder, and UEFI+'-kernel' on arm/virt, Paolo Bonzini, 2014/12/22
- [Qemu-devel] [PATCH v6 01/11] fw_cfg: hard separation between the MMIO and I/O port mappings, Paolo Bonzini, 2014/12/22
- [Qemu-devel] [PATCH v6 02/11] fw_cfg: move boards to fw_cfg_init_io() / fw_cfg_init_mem(), Paolo Bonzini, 2014/12/22
- [Qemu-devel] [PATCH v6 03/11] fw_cfg_mem: max access size and region size are the same for data register,
Paolo Bonzini <=
- [Qemu-devel] [PATCH v6 04/11] fw_cfg_mem: flip ctl_mem_ops and data_mem_ops to DEVICE_BIG_ENDIAN, Paolo Bonzini, 2014/12/22
- [Qemu-devel] [PATCH v6 05/11] exec: allows 8-byte accesses in subpage_ops, Paolo Bonzini, 2014/12/22
- [Qemu-devel] [PATCH v6 06/11] fw_cfg_mem: introduce the "data_width" property, Paolo Bonzini, 2014/12/22
- [Qemu-devel] [PATCH v6 07/11] fw_cfg_mem: expose the "data_width" property with fw_cfg_init_mem_wide(), Paolo Bonzini, 2014/12/22
- [Qemu-devel] [PATCH v6 08/11] arm: add fw_cfg to "virt" board, Paolo Bonzini, 2014/12/22
- [Qemu-devel] [PATCH v6 09/11] hw/loader: split out load_image_gzipped_buffer(), Paolo Bonzini, 2014/12/22
- [Qemu-devel] [PATCH v6 10/11] hw/arm: pass pristine kernel image to guest firmware over fw_cfg, Paolo Bonzini, 2014/12/22
- [Qemu-devel] [PATCH v6 11/11] hw/arm/virt: enable passing of EFI-stubbed kernel to guest UEFI firmware, Paolo Bonzini, 2014/12/22
- Re: [Qemu-devel] [PATCH v6 00/11] fw_cfg, bootorder, and UEFI+'-kernel' on arm/virt, Peter Maydell, 2014/12/22
- Re: [Qemu-devel] [PATCH v6 00/11] fw_cfg, bootorder, and UEFI+'-kernel' on arm/virt, Laszlo Ersek, 2014/12/23