Re: [Qemu-devel] [PATCH v6 0/4] qmp: Add "blockdev-backup"

[Markus Armbruster]

Fam Zheng <address@hidden> writes:

> v6: Add Eric's rev-by in 1/4.
>     Address minor comments in 2/4, 3/4.
>     Add John's rev-by in 3/4.
>
> v5: Address Max's and Markus' comments:
>     Split patch 1. (Markus)
>     Fix typos and pastos. (Markus, Max)
>     Actually acquire aio context. (Max)
>     Drop unnecessary initialization of fields in blockdev_backup_prepare. 
> (Max)
>     Add "sync" in the document example.
>     Add Max's rev-by in patch 4.
>
> The existing drive-backup command accepts a target file path, but that
> interface provides little flexibility on the properties of target block 
> device,
> compared to what is possible with "blockdev-add", "drive_add" or "-drive".
>
> This is also a building block to allow image fleecing (creating a point in 
> time
> snapshot and export with nbd-server-add).
>
> (For symmetry, blockdev-mirror will be added in a separate series.)

As I pointed out a review thread of v3, PATCH 2 adds new, unwanted uses
of QERR_ macros and ERROR_CLASS_DEVICE_NOT_FOUND.  Can be fixed on top.

Series
Reviewed-by: Markus Armbruster <address@hidden>