Re: [Qemu-devel] [PATCH v4] qemu-log: add log category for MMU info

[Peter Maydell]

On 15 December 2014 at 17:39, Peter Maydell <address@hidden> wrote:
> On 14 December 2014 at 18:29, Richard Henderson <address@hidden> wrote:
>> On 12/13/2014 08:48 AM, Antony Pavlov wrote:
>>> Running barebox on qemu-system-mips* with '-d unimp' overloads
>>> stderr by very very many mips_cpu_handle_mmu_fault() messages:
>>>
>>>   mips_cpu_handle_mmu_fault address=b80003fd ret 0 physical 
>>> 00000000180003fd prot 3
>>>   mips_cpu_handle_mmu_fault address=a0800884 ret 0 physical 
>>> 0000000000800884 prot 3
>>>   mips_cpu_handle_mmu_fault pc a080cd80 ad b80003fd rw 0 mmu_idx 0
>>>
>>> So it's very difficult to find LOG_UNIMP message.
>>>
>>> The mips_cpu_handle_mmu_fault() messages appear on enabling ANY
>>> logging! It's not very handy.
>>>
>>> Adding separate log category for *_cpu_handle_mmu_fault()
>>> logging fixes the problem.
>>>
>>> Signed-off-by: Antony Pavlov <address@hidden>
>>> Acked-by: Alexander Graf <address@hidden>
>>> ---
>>
>> Reviewed-by: Richard Henderson <address@hidden>
>
> Probably easiest if I apply this direct to master, given it
> touches several of the target-* backends. Any objections?

Applied, thanks.

-- PMM