[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix crash on spapr_tce_table_finalize()
|
From: |
Alexander Graf |
|
Subject: |
Re: [Qemu-devel] [PATCH] Fix crash on spapr_tce_table_finalize() |
|
Date: |
Wed, 17 Dec 2014 13:03:39 +0100 |
|
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 08.12.14 03:48, David Gibson wrote:
> spapr_tce_table_finalize() can SEGV if the object was not previously
> realized. In particular this can be triggered by running
> qemu-system-ppc -device spapr-tce-table,?
>
> The basic problem is that we have mismatched initialization versus
> finalization: spapr_tce_table_finalize() is attempting to undo things that
> are done in spapr_tce_table_realize(), not an instance_init function.
>
> Therefore, replace spapr_tce_table_finalize() with
> spapr_tce_table_unrealize().
>
> Signed-off-by: David Gibson <address@hidden>
Thanks, applied to ppc-next and added CC stable.
Alex