[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 1/1] target-tricore: fix offset masking in BO
|
From: |
Bastian Koppelmann |
|
Subject: |
Re: [Qemu-devel] [PATCH v1 1/1] target-tricore: fix offset masking in BOL format + typo |
|
Date: |
Fri, 12 Dec 2014 13:20:52 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 12/12/2014 10:25 AM, Alex Züpke wrote:
Fixes offset masking for BOL opcodes and a typo (LONF -> LONG)
Signed-off-by: Alex Zuepke <address@hidden>
Hi Alex,
good catch. I wonder how that slipped through my testsuit. However you
mail seems to be malformed. The patch went somehow into your signature.
Don't do that, please. It is easier for the reviewer and you, if he can
inline comments to the corresponding line, he wants to talk about. Also
you don't need a v1 for the first version of a patch and please group up
similar patches, e.g. for tricore.
The usual workflow with git would be, for your two patches:
1) git format-patch -2 --cover-letter
2) edit coverletter and say, what the patches are doing.
3) git send-email --to="address@hidden" --cc=... *.patch
Other than that, it looks good to me. If you resend your two patches
well formated, I'll add them to my tricore-next branch.
Cheers,
Bastian