[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-mips: Use local float status pointer acr
|
From: |
Leon Alrae |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-mips: Use local float status pointer across MSA macros |
|
Date: |
Thu, 11 Dec 2014 15:37:14 +0000 |
|
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 02/12/2014 17:51, Maciej W. Rozycki wrote:
> Reduce line wrapping throughout MSA helper macros by using a local float
> status pointer rather than referring to the float status through the
> environment each time. No functional change.
>
> Signed-off-by: Maciej W. Rozycki <address@hidden>
> ---
> Hi,
>
> The same float status applies across a single MSA operation (i.e. there
> can't be an MT thread context switch in the middle) so there is no need
> to get through the environment on each individual sub-operation. And at
> any reasonable optimisation level code generated should be the same if
> not better. The local pointer will help with a follow-up change that
> would otherwise make line wrapping unbearable.
>
> Please apply,
>
> Maciej
>
> qemu-mips-msa-helper-status.diff
> Index: qemu-git-trunk/target-mips/msa_helper.c
Reviewed-by: Leon Alrae <address@hidden>