qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 25/26] qcow2: Point to amend function in chec


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v4 25/26] qcow2: Point to amend function in check
Date: Thu, 11 Dec 2014 14:46:31 +0000
User-agent: Mutt/1.5.23 (2014-03-12)

On Wed, Dec 03, 2014 at 02:37:45PM +0100, Max Reitz wrote:
> If a reference count is not representable with the current refcount
> order, the image check should point to qemu-img amend for increasing the
> refcount order. However, qemu-img amend needs write access to the image
> which cannot be provided if the image is marked corrupt; and the image
> check will not mark the image consistent unless everything actually is
> consistent.
> 
> Therefore, if an image is marked corrupt and the image check encounters
> a reference count overflow, it cannot be fixed by using qemu-img amend
> to increase the refcount order. Instead, one has to use qemu-img convert
> to create a completely new copy of the image in this case.
> 
> Alternatively, we may want to give the user a way of manually removing
> the corrupt flag, maybe through qemu-img amend, but this is not part of
> this patch.
> 
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
>  block/qcow2-refcount.c | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Stefan Hajnoczi <address@hidden>

Attachment: pgpfqYNWik26F.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]