[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 25/26] qcow2: Point to amend function in chec
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v4 25/26] qcow2: Point to amend function in check |
Date: |
Thu, 11 Dec 2014 14:46:31 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Dec 03, 2014 at 02:37:45PM +0100, Max Reitz wrote:
> If a reference count is not representable with the current refcount
> order, the image check should point to qemu-img amend for increasing the
> refcount order. However, qemu-img amend needs write access to the image
> which cannot be provided if the image is marked corrupt; and the image
> check will not mark the image consistent unless everything actually is
> consistent.
>
> Therefore, if an image is marked corrupt and the image check encounters
> a reference count overflow, it cannot be fixed by using qemu-img amend
> to increase the refcount order. Instead, one has to use qemu-img convert
> to create a completely new copy of the image in this case.
>
> Alternatively, we may want to give the user a way of manually removing
> the corrupt flag, maybe through qemu-img amend, but this is not part of
> this patch.
>
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> block/qcow2-refcount.c | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Stefan Hajnoczi <address@hidden>
pgpfqYNWik26F.pgp
Description: PGP signature
- [Qemu-devel] [PATCH v4 21/26] qcow2: Split upgrade/downgrade paths for amend, (continued)
- [Qemu-devel] [PATCH v4 21/26] qcow2: Split upgrade/downgrade paths for amend, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 22/26] qcow2: Use intermediate helper CB for amend, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 23/26] qcow2: Add function for refcount order amendment, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 24/26] qcow2: Invoke refcount order amendment function, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 25/26] qcow2: Point to amend function in check, Max Reitz, 2014/12/03
- Re: [Qemu-devel] [PATCH v4 25/26] qcow2: Point to amend function in check,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v4 26/26] iotests: Add test for different refcount widths, Max Reitz, 2014/12/03
[Qemu-devel] [PATCH v4 15/26] iotests: Prepare for refcount_bits option, Max Reitz, 2014/12/03
[Qemu-devel] [PATCH v4 14/26] qcow2: Use symbolic macros in qcow2_amend_options, Max Reitz, 2014/12/03