Re: [Qemu-devel] [PATCH 1/1] Sort include/qemu/typedefs.h

[Dr. David Alan Gilbert]

* Alex Benn?e (address@hidden) wrote:
> 
> Dr. David Alan Gilbert (git) <address@hidden> writes:
> 
> > From: "Dr. David Alan Gilbert" <address@hidden>
> >
> > Mainly to make it less likely to conflict during merges.
> >
> > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> 
> I'm happy with the idea (having been adding stuff recently). However
> have you:
> 
> a) checked for typedefs no longer used by the wider code base
> b) audited for others using opaque types pulling in full definitions?

Nope; I just sorted it - so it's nice and simple; but yes it's
probably worth doing those at some point.

> Otherwise:
> 
> Reviewed-by: Alex Bennée <address@hidden>

Thanks,

Dave

> 
> Cheers,
> 
> -- 
> Alex Bennée
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK