[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 1/6] pci: reorganize QEMU_PCI_CAP_*
From: |
Hu Tao |
Subject: |
[Qemu-devel] [PATCH v3 1/6] pci: reorganize QEMU_PCI_CAP_* |
Date: |
Thu, 11 Dec 2014 10:20:23 +0800 |
This makes code more readable.
Signed-off-by: Hu Tao <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
---
include/hw/pci/pci.h | 39 ++++++++++++++++++++-------------------
1 file changed, 20 insertions(+), 19 deletions(-)
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index c352c7b..b18759a 100644
--- a/include/hw/pci/pci.h
+++ b/include/hw/pci/pci.h
@@ -142,25 +142,26 @@ enum {
/* Bits in cap_present field. */
enum {
- QEMU_PCI_CAP_MSI = 0x1,
- QEMU_PCI_CAP_MSIX = 0x2,
- QEMU_PCI_CAP_EXPRESS = 0x4,
-
- /* multifunction capable device */
-#define QEMU_PCI_CAP_MULTIFUNCTION_BITNR 3
- QEMU_PCI_CAP_MULTIFUNCTION = (1 << QEMU_PCI_CAP_MULTIFUNCTION_BITNR),
-
- /* command register SERR bit enabled */
-#define QEMU_PCI_CAP_SERR_BITNR 4
- QEMU_PCI_CAP_SERR = (1 << QEMU_PCI_CAP_SERR_BITNR),
- /* Standard hot plug controller. */
-#define QEMU_PCI_SHPC_BITNR 5
- QEMU_PCI_CAP_SHPC = (1 << QEMU_PCI_SHPC_BITNR),
-#define QEMU_PCI_SLOTID_BITNR 6
- QEMU_PCI_CAP_SLOTID = (1 << QEMU_PCI_SLOTID_BITNR),
- /* PCI Express capability - Power Controller Present */
-#define QEMU_PCIE_SLTCAP_PCP_BITNR 7
- QEMU_PCIE_SLTCAP_PCP = (1 << QEMU_PCIE_SLTCAP_PCP_BITNR),
+ QEMU_PCI_CAP_MSI_BITNR = 0,
+ QEMU_PCI_CAP_MSIX_BITNR,
+ QEMU_PCI_CAP_EXPRESS_BITNR,
+ QEMU_PCI_CAP_MULTIFUNCTION_BITNR, /* multifunction capable device */
+ QEMU_PCI_CAP_SERR_BITNR, /* command register SERR bit enabled */
+ QEMU_PCI_SHPC_BITNR, /* Standard hot plug controller */
+ QEMU_PCI_SLOTID_BITNR,
+ QEMU_PCIE_SLTCAP_PCP_BITNR, /* PCI Express capability - Power Controller
+ Present */
+};
+
+enum {
+ QEMU_PCI_CAP_MSI = (1 << QEMU_PCI_CAP_MSI_BITNR),
+ QEMU_PCI_CAP_MSIX = (1 << QEMU_PCI_CAP_MSIX_BITNR),
+ QEMU_PCI_CAP_EXPRESS = (1 << QEMU_PCI_CAP_EXPRESS_BITNR),
+ QEMU_PCI_CAP_MULTIFUNCTION = (1 << QEMU_PCI_CAP_MULTIFUNCTION_BITNR),
+ QEMU_PCI_CAP_SERR = (1 << QEMU_PCI_CAP_SERR_BITNR),
+ QEMU_PCI_CAP_SHPC = (1 << QEMU_PCI_SHPC_BITNR),
+ QEMU_PCI_CAP_SLOTID = (1 << QEMU_PCI_SLOTID_BITNR),
+ QEMU_PCIE_SLTCAP_PCP = (1 << QEMU_PCIE_SLTCAP_PCP_BITNR),
};
#define TYPE_PCI_DEVICE "pci-device"
--
1.9.3
- [Qemu-devel] [PATCH v3 0/6] Some PCI related cleanup patches, Hu Tao, 2014/12/10
- [Qemu-devel] [PATCH v3 1/6] pci: reorganize QEMU_PCI_CAP_*,
Hu Tao <=
- [Qemu-devel] [PATCH v3 5/6] pci: remove the limit parameter of pci_host_config_write_common, Hu Tao, 2014/12/10
- [Qemu-devel] [PATCH v3 4/6] pci: remove the limit parameter of pci_host_config_read_common, Hu Tao, 2014/12/10
- [Qemu-devel] [PATCH v3 2/6] pci: introduce pci_host_config_enabled(), Hu Tao, 2014/12/10
- [Qemu-devel] [PATCH v3 3/6] pci: define PCI_HOST_BRIDGE_CONFIG_ADDR and PCI_HOST_BRIDGE_CONFIG_DATA., Hu Tao, 2014/12/10
- [Qemu-devel] [PATCH v3 6/6] pci: introduce PCI_DEVFN_AUTO, Hu Tao, 2014/12/10
- [Qemu-devel] [PATCH v3 RESEND 6/6] pci: introduce PCI_DEVFN_AUTO, Hu Tao, 2014/12/10