[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 10/10] monitor: add vnc websockets
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 10/10] monitor: add vnc websockets |
Date: |
Wed, 10 Dec 2014 09:54:19 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 12/10/2014 02:37 AM, Gerd Hoffmann wrote:
> Add websockets bool to VncBasicInfo, report websocket server sockets,
> flag websocket client connections.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> qapi-schema.json | 5 ++++-
> ui/vnc.c | 14 ++++++++++++--
> 2 files changed, 16 insertions(+), 3 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 677a762..a945693 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -672,12 +672,15 @@
> #
> # @family: address family
> #
> +# @websocket: #optional true in case the socket is a websocket (since 2.2).
s/2.2/2.3/
> +#
> # Since: 2.1
> ##
> { 'type': 'VncBasicInfo',
> 'data': { 'host': 'str',
> 'service': 'str',
> - 'family': 'NetworkAddressFamily' } }
> + 'family': 'NetworkAddressFamily',
> + '*websocket': 'bool' } }
Is it optional because you omit it when false? Why not just always
output the bool, so that clients know they are talking to a new-enough
qemu that knows about websockets (and this is explicitly not one), vs.
having to guess that the omission of the bool implies that it is not
rather than being an older qemu.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 00/10] vnc: add support for multiple vnc displays, Gerd Hoffmann, 2014/12/10
- [Qemu-devel] [PATCH v2 06/10] vnc: update docs/multiseat.txt, Gerd Hoffmann, 2014/12/10
- [Qemu-devel] [PATCH v2 03/10] vnc: add display id to acl names, Gerd Hoffmann, 2014/12/10
- [Qemu-devel] [PATCH v2 01/10] vnc: remove vnc_display global, Gerd Hoffmann, 2014/12/10
- [Qemu-devel] [PATCH v2 04/10] vnc: switch to QemuOpts, allow multiple servers, Gerd Hoffmann, 2014/12/10
- [Qemu-devel] [PATCH v2 10/10] monitor: add vnc websockets, Gerd Hoffmann, 2014/12/10
- Re: [Qemu-devel] [PATCH v2 10/10] monitor: add vnc websockets,
Eric Blake <=
- [Qemu-devel] [PATCH v2 07/10] vnc: track & limit connections, Gerd Hoffmann, 2014/12/10
- [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command, Gerd Hoffmann, 2014/12/10
- Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command, Eric Blake, 2014/12/10
- Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command, Daniel P. Berrange, 2014/12/11
- Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command, Gerd Hoffmann, 2014/12/11
- Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command, Daniel P. Berrange, 2014/12/11
- Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command, Gerd Hoffmann, 2014/12/15