|
From: | Bryan D. Payne |
Subject: | Re: [Qemu-devel] [PATCH] qmp: extend QMP to provide read/write access to physical memory |
Date: | Fri, 5 Dec 2014 13:25:10 -0800 |
Actually, it sends it through a UNIX domain socket. Still I/O, just
different I/O. "Faster" is plausible, but by how much I can't say
without measurements. "Several orders of magnitude" needs evidence.
Based on your qapi-schema.json change only, I figure your new command
sets up a special-purpose monitor-like thing on a newly created a UNIX
domain socket. This monitor-like thing talks its own language, which is
so far undocmented.
Why restrict this to a UNIX domain socket? In other places involving
byte streams we use a QEMU character device.
Can you explain why you need a separate stream instead of embedding the
conversation in QMP? We already have such embedded I/O: ringbuf-read,
ringbuf-write. Yes, it got multiple documented bugs, but that's because
it was badly done, not because such a thing couldn't be done nicely.
If you add a separate stream talking its own language, you get to
document the language. A file in docs/ should do. The QMP command
documentation should point to it.
[Prev in Thread] | Current Thread | [Next in Thread] |